Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to String based URI #33673

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Revert back to String based URI #33673

merged 1 commit into from
Feb 23, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #33671

Reverts uri(URI) back to the previous uri(String). URI.create has issues where there is no host part when using an IP-style Azurite URL (https://devaccount1.blob.0.0.0.0:10000) where uri(String) doesn't have the same issue.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Feb 22, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft merged commit 4f2654d into Azure:main Feb 23, 2023
@alzimmermsft alzimmermsft deleted the AzNetty_RevertBackToStringBasedUri branch February 23, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core HttpClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Azure Blob Storage SDK 12.20.2 breaks parsing of connection strings for Azurite emulator [REGRESSION]
3 participants
@alzimmermsft @azure-sdk @lmolkova